Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync console theme color with the vs-code theme #3747

Closed
polamoros opened this issue Aug 9, 2023 · 3 comments · Fixed by #3805
Closed

Sync console theme color with the vs-code theme #3747

polamoros opened this issue Aug 9, 2023 · 3 comments · Fixed by #3805
Assignees
@polamoros
Labels
🛫 console Console ✨ enhancement New feature or request 🔌 vscode-extension Issues related to the Wing VS Code extension

Comments

@polamoros
Copy link
Contributor

Feature Spec

Use the vs-code theme main color in Console theme when runing it in vs-code

image

Use Cases

runing console in vs-code.

Implementation Notes

No response

Component

Wing Console

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.
@polamoros polamoros added ✨ enhancement New feature or request 🛫 console Console 🔌 vscode-extension Issues related to the Wing VS Code extension labels Aug 9, 2023
@polamoros polamoros self-assigned this Aug 9, 2023
@polamoros polamoros added this to Wing Aug 9, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New - not properly defined in Wing Aug 9, 2023
@polamoros polamoros moved this from 🆕 New - not properly defined to 🤝 Backlog - handoff to owners in Wing Aug 9, 2023
@polamoros polamoros moved this from 🤝 Backlog - handoff to owners to 🏗 In progress in Wing Aug 9, 2023
@olivernybroe
Copy link
Contributor

How is this supposed to work? Do you supply a color palette so it can match what the person has set inside the IDE?

@ainvoner ainvoner moved this from 🏗 In progress to 👀 In review in Wing Aug 17, 2023
@ainvoner ainvoner moved this from 👀 In review to 🏗 In progress in Wing Aug 17, 2023
@ainvoner ainvoner moved this from 🏗 In progress to 👀 In review in Wing Aug 17, 2023
@ainvoner ainvoner mentioned this issue Aug 17, 2023
Merged
@mergify mergify bot closed this as completed in #3805 Aug 17, 2023
mergify bot pushed a commit that referenced this issue Aug 17, 2023
@polamoros
feat(console): sync console theme color with the vs code theme (#3805)
34f3175 
This PR syncs the Console theme color with the vs-code theme.

Changing the map colors (applied in the PR):

https://github.com/winglang/wing/assets/5547636/3d5f8d0c-dc2f-457a-9b40-45b1ea0d588a

Without changing the map colors:

https://github.com/winglang/wing/assets/5547636/404a0921-9f65-4e60-9398-b67bb5a650a4

resolves: #3747
*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Wing Aug 17, 2023
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.25.16.

@polamoros
Copy link
Contributor Author

polamoros commented Aug 17, 2023 •
edited
Loading

How is this supposed to work? Do you supply a color palette so it can match what the person has set inside the IDE?

Hey @olivernybroe!

We just released this change!
We're using the base color from the VS Code theme to generate the different background colors of the console.
You can easily do the same in the IntelliJ plugin by adding a 'color' query parameter to the console iframe URL.

We will improve it soon by adding a proper theme configuration option to the createConsoleApp function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@polamoros polamoros

Labels
🛫 console Console ✨ enhancement New feature or request 🔌 vscode-extension Issues related to the Wing VS Code extension
Projects
Wing
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(console): sync console theme color with the vs code theme winglang/wing
3 participants
@polamoros @olivernybroe @monadabot