-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redis can't be tested in tf-aws / us-east-1 #4126
Comments
summarizing my chat with @staycoolcall911 about why this happens: Looks like the AWS API is assigning an AZ for the subnet if none was specified:
In the test case this apparently happens to be the AZ in us-east-1 where that ElastiCache instance type is not available. The docs of ElastiCache aren’t stating anything about limited availability zone support for regions. They are only talking about different instance types in different regions. https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/RegionsAndAZs.html In regards to why this is not happening for the "normal" deployment, I don't know. Don't even know if it's working deterministically or just by randomly by accident. Also, perhaps In any case, might be a good idea fetch availability zones and assign one explicitly to get rid of the AWS randomness. |
Ah, it might actually be the generic one https://docs.aws.amazon.com/cli/latest/reference/ec2/describe-instance-type-offerings.html |
Nope :/
|
@skorfmann The reason why the deployment fails is because the You can generate the above table with the following command:
|
I will deploy a fix later. |
ahh, that was the trick 💡 😄 |
Currently, when a new Wing app is created for AWS targets, it's left up to AWS to choose a random AZ in which to deploy the private and public subnets. With this change, we tell AWS that we always want to deploy to the first AZ of whatever region specified by the user, which is generally the one that has the broadest range of services available. Closes #4126 *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
Congrats! 🚀 This was released in Wing 0.31.5. |
I tried this:
triggered through winglang/examples#20 (the todo app example)
This happened:
I expected this:
it can be tested without errors and without having to worry about availability zones.
note: a normal
wing compile -t tf-aws main.w && terraform init / apply
works in the same region.Is there a workaround?
potentially testing in a different region, but haven't tried
Component
SDK
Wing Version
0.29.6
Node.js Version
20.6.0
Platform(s)
MacOS
Anything else?
No response
Community Notes
The text was updated successfully, but these errors were encountered: