Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove release commenter for now #3427

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Conversation

MarkMcCulloh
Copy link
Contributor

@MarkMcCulloh MarkMcCulloh commented Jul 13, 2023

It doesn't work properly for our new dev/main setup, will have to figure out an alternative.
Removing it in the meantime because it's causing confusion.

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Monada Contribution License.

@MarkMcCulloh MarkMcCulloh added the pr/backport backport from dev to main label Jul 13, 2023
@MarkMcCulloh MarkMcCulloh requested a review from a team as a code owner July 13, 2023 14:43
Copy link
Contributor

@staycoolcall911 staycoolcall911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a list of things we'd like to add back when we're out of this winter? Let's add this one

@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2023

Thank you for contributing! Your pull request will be updated from dev and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 988e33a into dev Jul 13, 2023
@mergify mergify bot deleted the mark/remove-release-commenter branch July 13, 2023 16:34
mergify bot pushed a commit that referenced this pull request Jul 13, 2023
It doesn't work properly for our new dev/main setup, will have to figure out an alternative.
Removing it in the meantime because it's causing confusion.

## Checklist

- [ ] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [ ] Description explains motivation and solution
- [ ] Tests added (always)
- [ ] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Monada Contribution License](https://www.winglang.io/terms-and-policies/contribution-license.html)*.

(cherry picked from commit 988e33a)
MarkMcCulloh added a commit that referenced this pull request Jul 13, 2023
Co-authored-by: Mark McCulloh <Mark.McCulloh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/backport backport from dev to main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants