Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: url shortener not compiling #3485

Merged
merged 6 commits into from
Jul 17, 2023
Merged

fix: url shortener not compiling #3485

merged 6 commits into from
Jul 17, 2023

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Jul 17, 2023

The url shortener example was not compiling.

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Monada Contribution License.

@eladb eladb requested a review from a team as a code owner July 17, 2023 08:35
@eladb eladb changed the title fix: modernize url shortener fix: url shortener not compiling Jul 17, 2023
@eladb eladb added the pr/backport backport from dev to main label Jul 17, 2023
@eladb eladb requested a review from Chriscbr July 17, 2023 08:37
examples/proposed/url-shortener.w Show resolved Hide resolved
examples/proposed/url-shortener.w Outdated Show resolved Hide resolved
examples/proposed/url-shortener.w Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Jul 17, 2023

Thank you for contributing! Your pull request will be updated from dev and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 241ec90 into dev Jul 17, 2023
@mergify mergify bot deleted the eladb/fix-url-shortener branch July 17, 2023 11:49
mergify bot pushed a commit that referenced this pull request Jul 17, 2023
The url shortener example was not compiling.

## Checklist

- [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [x] Description explains motivation and solution
- [x] Tests added (always)
- [x] Docs updated (only required for features)
- [x] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Monada Contribution License](https://www.winglang.io/terms-and-policies/contribution-license.html)*.

(cherry picked from commit 241ec90)
staycoolcall911 added a commit that referenced this pull request Jul 18, 2023
Co-authored-by: Elad Ben-Israel <eladb@monada.co>
Co-authored-by: Uri Bar <106860404+staycoolcall911@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/backport backport from dev to main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants