Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): add Queue.push in sdk tests #3886

Merged
merged 7 commits into from
Sep 11, 2023
Merged

chore(sdk): add Queue.push in sdk tests #3886

merged 7 commits into from
Sep 11, 2023

Conversation

garysassano
Copy link
Collaborator

I noticed Queue.push() was missing in the SDK tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@garysassano garysassano requested a review from a team as a code owner August 19, 2023 00:02
@monadabot
chore: self mutation
51dc8eb 
Signed-off-by: monada-bot[bot] <monabot@monada.co>
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 19, 2023
tsuf239
tsuf239 suggested changes Aug 21, 2023
View reviewed changes
examples/tests/sdk_tests/queue/push.w Outdated Show resolved Hide resolved
@tsuf239 tsuf239 removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 21, 2023
@garysassano garysassano changed the title chore(sdk): add queue.push in sdk tests chore(sdk): add Queue.push in sdk tests Aug 23, 2023
@monadabot
chore: self mutation
9a26430 
Signed-off-by: monada-bot[bot] <monabot@monada.co>
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 23, 2023
@tsuf239 tsuf239 removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Sep 3, 2023
@tsuf239
Copy link
Contributor

tsuf239 commented Sep 4, 2023

hey :)
the tests still aren't passing, probably because of the use of approxSize, I'll take care of it and commit

@tsuf239
Copy link
Contributor

tsuf239 commented Sep 11, 2023

image Finally!

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Sep 11, 2023
@tsuf239 tsuf239 removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Sep 11, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2023

Thanks for contributing, @garysassano! This PR will now be added to the merge queue, or immediately merged if sdk-test-queue-push is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Sep 11, 2023
@mergify
Merge of #3886
dbb12f7
@mergify mergify bot mentioned this pull request Sep 11, 2023
Closed
14 tasks
@mergify mergify bot merged commit 1ac7acf into main Sep 11, 2023
14 checks passed
@mergify mergify bot deleted the sdk-test-queue-push branch September 11, 2023 09:43
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.29.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsuf239 tsuf239 tsuf239 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garysassano @tsuf239 @monadabot