Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(compiler)!: remove panic built-in method #3950

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Conversation

staycoolcall911
Copy link
Contributor

@staycoolcall911 staycoolcall911 commented Aug 24, 2023

Don't panic! Stay cool...

This minor breaking change was staring at me for too long - better remove panic() before anyone starts using it.

Closes #2055

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@staycoolcall911 staycoolcall911 requested a review from a team as a code owner August 24, 2023 12:55
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 24, 2023
@MarkMcCulloh MarkMcCulloh removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Aug 24, 2023
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call911

@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2023

Thanks for contributing, @staycoolcall911! This PR will now be added to the merge queue, or immediately merged if urib/dont-panic is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Aug 24, 2023
mergify bot added a commit that referenced this pull request Aug 24, 2023
@mergify mergify bot merged commit 01a08af into main Aug 24, 2023
11 checks passed
@mergify mergify bot deleted the urib/dont-panic branch August 24, 2023 21:46
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.26.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of panic Wing function for now
4 participants