Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): tests are causing ci timeouts #4154

Merged
merged 4 commits into from
Sep 14, 2023

Conversation

polamoros
Copy link
Contributor

@polamoros polamoros commented Sep 12, 2023

Improve console tests to prevent CI timeouts caused by some tests randomly getting stuck.

resolves #4153

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@polamoros polamoros marked this pull request as ready for review September 12, 2023 08:00
@polamoros polamoros marked this pull request as draft September 12, 2023 09:05
@polamoros polamoros marked this pull request as ready for review September 12, 2023 12:30
@monadabot
Copy link
Contributor

monadabot commented Sep 12, 2023

Console preview environment is available at https://wing-console-pr-4154.fly.dev 🚀

Updated (UTC): 2023-09-13 07:58

@MarkMcCulloh
Copy link
Contributor

image

Not sure if you saw, but a failed test still passes the build (it's just considered flakey). I think these kind of tests probably shouldn't allow for any flakiness

@polamoros
Copy link
Contributor Author

image Not sure if you saw, but a failed test still passes the build (it's just considered flakey). I think these kind of tests probably shouldn't allow for any flakiness

The test was flagged as flaky because it timed out during the teardown process. (see here)

Tests are usually flagged as flaky when they succeed after a retry.
I agree that we shouldn't allow flakiness, but if we remove the retries, we'll have many CI failures due to the console tests..

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2023

Thanks for contributing, @polamoros! This PR will now be added to the merge queue, or immediately merged if 4153-console-tests-are-causing-ci-timeouts is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Sep 14, 2023
@mergify mergify bot merged commit e500574 into main Sep 14, 2023
11 checks passed
@mergify mergify bot deleted the 4153-console-tests-are-causing-ci-timeouts branch September 14, 2023 08:44
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.30.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

console tests are causing ci timeouts
4 participants