Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): add Max-Age CORS header for cloud.Api #4194

Merged
merged 15 commits into from
Sep 20, 2023
Merged

chore(sdk): add Max-Age CORS header for cloud.Api #4194

merged 15 commits into from
Sep 20, 2023

Conversation

garysassano
Copy link
Collaborator

Adding missing CORS header.

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@garysassano garysassano requested a review from a team as a code owner September 17, 2023 09:21
@monadabot
Copy link
Contributor

monadabot commented Sep 17, 2023 •
edited
Loading

Console preview environment is available at https://wing-console-pr-4194.fly.dev 🚀

Updated (UTC): 2023-09-18 21:29

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Sep 17, 2023
monadabot and others added 4 commits September 17, 2023 14:25
@monadabot
Merge branch 'main' into garysassano/fix-api-cors
8189abc
@monadabot
chore: self mutation (build.diff)
ffa26ca 
Signed-off-by: monada-bot[bot] <monabot@monada.co>
@monadabot
chore: self mutation (e2e-1of2.diff)
f563a88 
Signed-off-by: monada-bot[bot] <monabot@monada.co>
@monadabot
chore: self mutation (e2e-2of2.diff)
c1f5739 
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Chriscbr
Chriscbr reviewed Sep 18, 2023
View reviewed changes
libs/wingsdk/src/cloud/api.ts Outdated Show resolved Hide resolved
libs/wingsdk/src/cloud/api.ts Outdated Show resolved Hide resolved
garysassano and others added 4 commits September 18, 2023 18:00
@garysassano @Chriscbr
Update libs/wingsdk/src/cloud/api.ts
ab5a6cf 
Co-authored-by: Chris Rybicki <chrisr@monada.co>
@garysassano @Chriscbr
Update libs/wingsdk/src/cloud/api.ts
32c069a 
Co-authored-by: Chris Rybicki <chrisr@monada.co>
@garysassano
fix JSDoc
efdda2b
@garysassano
fix import
f70b336
garysassano and others added 6 commits September 18, 2023 19:37
@garysassano @Chriscbr
Update examples/tests/valid/website_with_api.main.w
e875cd7 
Co-authored-by: Chris Rybicki <chrisr@monada.co>
@garysassano
fix api interface
21c1546
@monadabot
Merge branch 'main' into garysassano/fix-api-cors
ef88657
@monadabot
chore: self mutation (build.diff)
f262409 
Signed-off-by: monada-bot[bot] <monabot@monada.co>
@monadabot
chore: self mutation (e2e-1of2.diff)
31d2f39 
Signed-off-by: monada-bot[bot] <monabot@monada.co>
@garysassano
update api test
d7edae8
@staycoolcall911 staycoolcall911 removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Sep 20, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 20, 2023

Thanks for contributing, @garysassano! This PR will now be added to the merge queue, or immediately merged if garysassano/fix-api-cors is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Sep 20, 2023
@mergify
Merge of #4194
483f2dc
@mergify mergify bot mentioned this pull request Sep 20, 2023
Closed
14 tasks
@mergify mergify bot merged commit 2b2fb52 into main Sep 20, 2023
14 checks passed
@mergify mergify bot deleted the garysassano/fix-api-cors branch September 20, 2023 09:15
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.31.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chriscbr Chriscbr Chriscbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@garysassano @monadabot @Chriscbr @staycoolcall911