fix(sdk): ambiguous api paths are allowed #4352
Conversation
Signed-off-by: monada-bot[bot] <monabot@monada.co>
monadabot
added
the
⚠️ pr/review-mutation
Signed-off-by: monada-bot[bot] <monabot@monada.co>
|
the tests pass on aws! |
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
This reverts commit 825217c.
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
|
Another option I can suggest is to comment out the invalid test code and I'll open an issue and fix it at our end :) |
Alright, if you're fine with this approach, it works for me too. |
|
@tsuf239 Apparently it won't work for a file without any tests |
|
I see, so it's ok to remove this file, I'll add it back in a new PR with the path serialization fixed |
tsuf239
removed
the
⚠️ pr/review-mutation
|
Thanks for contributing, @gcfbn! This PR will now be added to the merge queue, or immediately merged if |
leftover from this task: #4352 ## Checklist - [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [x] Description explains motivation and solution - [ ] Tests added (always) - [ ] Docs updated (only required for features) - [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
|
Congrats! 🚀 This was released in Wing 0.34.16. |
Fixes the issue #4052 by adding a check if newly added path is ambiguous with paths already added to the API. I've re-created the #4291 PR, as it got stuck on merging main to the feature branch.
Checklist
pr/e2e-fulllabel if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.