Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: format tree-sitter scanner and remove implicit switch fallthrough #4476

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

MarkMcCulloh
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@MarkMcCulloh MarkMcCulloh requested a review from a team as a code owner October 9, 2023 13:35
@monadabot
Copy link
Contributor

Console preview environment is available at https://wing-console-pr-4476.fly.dev 🚀

Last Updated (UTC) 2023-10-09 13:56

@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜🟥⬜
Benchmark Before After Change
version 114ms±5.41 116ms±2.91 +2ms (+2.12%)⬜
functions_10.test.w -t sim 1052ms±22.88 1052ms±22.88 0ms (-0.04%)⬜
functions_10.test.w -t tf-aws 6321ms±92.16 6333ms±65.5 +12ms (+0.19%)⬜
jsii_big.test.w -t sim 5582ms±118.66 5553ms±41.45 -29ms (-0.51%)⬜
jsii_big.test.w -t tf-aws 5765ms±85.55 5713ms±49.1 -52ms (-0.9%)⬜
hello_world.test.w -t sim 961ms±37.25 929ms±19.75 -32ms (-3.34%)⬜
hello_world.test.w -t tf-aws 7749ms±65.58 7612ms±76.6 -136ms (-1.76%)⬜
empty.test.w -t sim 879ms±10.5 879ms±13.47 ...
empty.test.w -t tf-aws 1123ms±24.58 1096ms±23.67 -27ms (-2.45%)⬜
jsii_small.test.w -t sim 885ms±10.29 900ms±32.94 +15ms (+1.69%)⬜
jsii_small.test.w -t tf-aws 1102ms±15.35 1133ms±36.58 +31ms (+2.85%)⬜
functions_1.test.w -t sim 962ms±14.66 1075ms±28.04 +113ms (+11.76%)🟥
functions_1.test.w -t tf-aws 3536ms±89.46 3387ms±89.5 -149ms (-4.21%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 116ms 106ms 121ms 3ms 4ms
functions_10.test.w -t sim 1052ms 1007ms 1117ms 23ms 32ms
functions_10.test.w -t tf-aws 6333ms 6108ms 6532ms 66ms 92ms
jsii_big.test.w -t sim 5553ms 5344ms 5645ms 41ms 58ms
jsii_big.test.w -t tf-aws 5713ms 5613ms 5847ms 49ms 69ms
hello_world.test.w -t sim 929ms 890ms 1000ms 20ms 28ms
hello_world.test.w -t tf-aws 7612ms 7488ms 7874ms 77ms 107ms
empty.test.w -t sim 879ms 858ms 905ms 13ms 19ms
empty.test.w -t tf-aws 1096ms 1059ms 1181ms 24ms 33ms
jsii_small.test.w -t sim 900ms 851ms 1013ms 33ms 46ms
jsii_small.test.w -t tf-aws 1133ms 1081ms 1227ms 37ms 51ms
functions_1.test.w -t sim 1075ms 969ms 1148ms 28ms 39ms
functions_1.test.w -t tf-aws 3387ms 3184ms 3626ms 90ms 125ms
Last Updated (UTC) 2023-10-09 14:10

@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2023

Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if mark/scanner is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Oct 9, 2023
@mergify mergify bot merged commit 1662eff into main Oct 9, 2023
15 checks passed
@mergify mergify bot deleted the mark/scanner branch October 9, 2023 15:00
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.36.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants