Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): allow Node.js 20 for cloud.Function on tf-azure platform #5962

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

garysassano
Copy link
Collaborator

AzureRM Terraform provider v3.96.0 adds Azure Functions Support for Node.js 20, resolving the problem with the deployment.

Closes #5623

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@garysassano garysassano requested a review from a team as a code owner March 17, 2024 15:00
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @eladb
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot
Copy link
Contributor

Console preview environment is available at https://wing-console-pr-5962.fly.dev 🚀

Last Updated (UTC) 2024-03-17 15:06

@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline ⬜⬜🟥🟥⬜⬜⬜⬜⬜🟥🟥🟥🟥
Benchmark Before After Change
version 61ms±1.6 60ms±0.89 -1ms (-1.93%)⬜
empty.test.w -t sim 487ms±2.84 487ms±3.41 ...
empty.test.w -t tf-aws 702ms±6.77 725ms±11.01 +24ms (+3.41%)🟥
hello_world.test.w -t sim 513ms±4.02 522ms±3.72 +9ms (+1.76%)🟥
hello_world.test.w -t tf-aws 1646ms±12.11 1644ms±9 -2ms (-0.12%)⬜
functions_10.test.w -t sim 595ms±5.56 596ms±5.25 +2ms (+0.25%)⬜
functions_10.test.w -t tf-aws 2220ms±10.36 2231ms±13.39 +11ms (+0.5%)⬜
jsii_small.test.w -t sim 487ms±5.33 492ms±3.88 +4ms (+0.91%)⬜
jsii_small.test.w -t tf-aws 706ms±5.87 718ms±3.95 +12ms (+1.7%)⬜
jsii_big.test.w -t sim 2889ms±10.02 2918ms±11.16 +28ms (+0.99%)🟥
jsii_big.test.w -t tf-aws 3100ms±11.89 3132ms±14.2 +32ms (+1.02%)🟥
functions_1.test.w -t sim 513ms±5.21 525ms±4.14 +12ms (+2.32%)🟥
functions_1.test.w -t tf-aws 939ms±5.48 972ms±5.23 +33ms (+3.5%)🟥

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 60ms 59ms 63ms 1ms 1ms
empty.test.w -t sim 487ms 477ms 494ms 3ms 5ms
empty.test.w -t tf-aws 725ms 706ms 760ms 11ms 15ms
hello_world.test.w -t sim 522ms 513ms 529ms 4ms 5ms
hello_world.test.w -t tf-aws 1644ms 1626ms 1668ms 9ms 13ms
functions_10.test.w -t sim 596ms 584ms 606ms 5ms 7ms
functions_10.test.w -t tf-aws 2231ms 2201ms 2269ms 13ms 19ms
jsii_small.test.w -t sim 492ms 482ms 500ms 4ms 5ms
jsii_small.test.w -t tf-aws 718ms 711ms 729ms 4ms 6ms
jsii_big.test.w -t sim 2918ms 2894ms 2948ms 11ms 16ms
jsii_big.test.w -t tf-aws 3132ms 3098ms 3169ms 14ms 20ms
functions_1.test.w -t sim 525ms 515ms 534ms 4ms 6ms
functions_1.test.w -t tf-aws 972ms 960ms 982ms 5ms 7ms
Last Updated (UTC) 2024-03-17 15:11

Copy link
Contributor

mergify bot commented Mar 18, 2024

Thanks for contributing, @garysassano! This PR will now be added to the merge queue, or immediately merged if gary/azure-node-20 is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Mar 18, 2024
mergify bot added a commit that referenced this pull request Mar 18, 2024
@mergify mergify bot merged commit f5b3bf4 into main Mar 18, 2024
16 checks passed
@mergify mergify bot deleted the gary/azure-node-20 branch March 18, 2024 13:32
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.61.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure functions don't support node 20
3 participants