Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): code sample for cloud.Function that doesn't compile #6054

Merged
merged 6 commits into from
Mar 25, 2024

Conversation

ShaiBer
Copy link
Contributor

@ShaiBer ShaiBer commented Mar 25, 2024

Fix multiple errors in code sample of cloud.Function that doesn't compile.

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@ShaiBer ShaiBer requested a review from a team as a code owner March 25, 2024 13:42
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Mar 25, 2024
.gitignore Show resolved Hide resolved
@ShaiBer ShaiBer requested a review from eladb March 25, 2024 14:20
@monadabot
Copy link
Contributor

monadabot commented Mar 25, 2024

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 61ms±1.81 59ms±0.43 -3ms (-4.18%)⬜
empty.test.w -t sim 353ms±4.87 355ms±6.47 +3ms (+0.75%)⬜
empty.test.w -t tf-aws 587ms±5.96 588ms±5.09 +1ms (+0.12%)⬜
hello_world.test.w -t sim 387ms±4.76 387ms±5.42 0ms (-0.03%)⬜
hello_world.test.w -t tf-aws 1519ms±8.02 1536ms±16.39 +17ms (+1.12%)⬜
functions_10.test.w -t sim 465ms±6.67 468ms±7.12 +4ms (+0.77%)⬜
functions_10.test.w -t tf-aws 2118ms±9.05 2126ms±14.03 +8ms (+0.36%)⬜
jsii_small.test.w -t sim 357ms±3.08 362ms±4.11 +5ms (+1.37%)⬜
jsii_small.test.w -t tf-aws 597ms±8.14 605ms±8.28 +8ms (+1.28%)⬜
jsii_big.test.w -t sim 2790ms±16.6 2784ms±5.82 -6ms (-0.22%)⬜
jsii_big.test.w -t tf-aws 3001ms±8.56 3001ms±6.66 -1ms (-0.02%)⬜
functions_1.test.w -t sim 383ms±5.24 388ms±4.75 +4ms (+1.08%)⬜
functions_1.test.w -t tf-aws 824ms±6.61 823ms±4.81 0ms (-0.05%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 59ms 58ms 60ms 0ms 1ms
empty.test.w -t sim 355ms 341ms 367ms 6ms 9ms
empty.test.w -t tf-aws 588ms 576ms 598ms 5ms 7ms
hello_world.test.w -t sim 387ms 379ms 402ms 5ms 8ms
hello_world.test.w -t tf-aws 1536ms 1512ms 1587ms 16ms 23ms
functions_10.test.w -t sim 468ms 444ms 479ms 7ms 10ms
functions_10.test.w -t tf-aws 2126ms 2100ms 2150ms 14ms 20ms
jsii_small.test.w -t sim 362ms 355ms 373ms 4ms 6ms
jsii_small.test.w -t tf-aws 605ms 588ms 624ms 8ms 12ms
jsii_big.test.w -t sim 2784ms 2768ms 2795ms 6ms 8ms
jsii_big.test.w -t tf-aws 3001ms 2988ms 3018ms 7ms 9ms
functions_1.test.w -t sim 388ms 380ms 400ms 5ms 7ms
functions_1.test.w -t tf-aws 823ms 816ms 837ms 5ms 7ms
Last Updated (UTC) 2024-03-25 14:38

@Chriscbr Chriscbr removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Mar 25, 2024
Copy link
Contributor

mergify bot commented Mar 25, 2024

Thanks for contributing, @ShaiBer! This PR will now be added to the merge queue, or immediately merged if fix-function-code-sample is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Mar 25, 2024
@mergify mergify bot merged commit 9ac19f2 into main Mar 25, 2024
15 checks passed
@mergify mergify bot deleted the fix-function-code-sample branch March 25, 2024 17:24
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.64.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants