Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): improve explorer out of bounds experience #6873

Merged
merged 12 commits into from
Jul 10, 2024

Conversation

skyrpex
Copy link
Contributor

@skyrpex skyrpex commented Jul 9, 2024

This changeset increases the explorer's threshold used by the "Out of bounds" alert, meaning that it will appear before losing track of the nodes in the explorer. Additionally, the viewport will never leave the rendered area completely, even after resizing the browser window or the panels.

Fixes #4699.

This changeset increases the explorer's threshold used by the "Out of bounds" alert, meaning that it will appear before losing track of the nodes in the explorer.
Copy link

github-actions bot commented Jul 9, 2024

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot
Copy link
Contributor

monadabot commented Jul 9, 2024

Console preview environment is available at https://wing-console-pr-6873.fly.dev 🚀

Last Updated (UTC) 2024-07-10 07:45

@skyrpex skyrpex marked this pull request as draft July 9, 2024 13:03
@skyrpex
Copy link
Contributor Author

skyrpex commented Jul 9, 2024

Converting to draft and adding more features...

@skyrpex skyrpex marked this pull request as ready for review July 9, 2024 13:54
@polamoros
Copy link
Contributor

There is a "flash" when using the zoom-to-fit button. Not sure if it is intended.

Screen.Recording.2024-07-09.at.16.15.39.mov

@skyrpex
Copy link
Contributor Author

skyrpex commented Jul 9, 2024

There is a "flash" when using the zoom-to-fit button. Not sure if it is intended.

Screen.Recording.2024-07-09.at.16.15.39.mov

Yeah, it's caused by re-rendering... Not sure how to fix it right now, so I'm removing the transition altogether.

Copy link
Contributor

mergify bot commented Jul 10, 2024

Thanks for contributing, @skyrpex! This PR will now be added to the merge queue, or immediately merged if improve-console-explorer-out-of-bounds-experience is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Jul 10, 2024
@mergify mergify bot merged commit dab00cb into main Jul 10, 2024
14 checks passed
@mergify mergify bot deleted the improve-console-explorer-out-of-bounds-experience branch July 10, 2024 09:53
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.77.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content disappears from Wing Console
3 participants