Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winston 3 #29

Merged
merged 2 commits into from
Sep 18, 2018
Merged

Winston 3 #29

merged 2 commits into from
Sep 18, 2018

Conversation

mgibeau
Copy link
Member

@mgibeau mgibeau commented Aug 28, 2018

This PR adds support for Winston 3 (#28). I bumped the version to 3.0.0 as I had to refactor and drop a bunch of options. I updated the tests but I haven't checked for backward compatibility...

Also in this update:

  • Updated redis dependency
  • Updated async dependency
  • Requires NodeJS 8+

@yads
Copy link
Contributor

yads commented Sep 13, 2018

Thanks for this. I can merge it, although it seems like the main maintainers of this project (the ones with npm push access) have abandoned this project. I would suggest creating your own fork of this project.

@mgibeau
Copy link
Member Author

mgibeau commented Sep 13, 2018

Sure, no problem, thanks for the follow up.

@mgibeau mgibeau closed this Sep 13, 2018
@binarymist
Copy link

What's the state of this project and/or your fork @mgibeau ?

@DABH DABH reopened this Sep 18, 2018
@DABH
Copy link
Contributor

DABH commented Sep 18, 2018

Reopening this because @indexzero gave @mgibeau write access to this repo — so hopefully he can take over as the maintainer and get this working well for winston@3. This PR should probably be merged — we need some starting point at least for a winston@3 version — though I have not taken a careful look at it. If @mgibeau takes over then he should feel free to merge this and do whatever is necessary to keep this working well for winston@3 :) Thanks all!

@DABH
Copy link
Contributor

DABH commented Sep 18, 2018

And also @yads @mgibeau if you feel there is a npm release that should happen, mention me or indexzero, we will try to cut a release or give you access on npm. Thanks!

@mgibeau mgibeau closed this Sep 18, 2018
@mgibeau mgibeau reopened this Sep 18, 2018
@mgibeau
Copy link
Member Author

mgibeau commented Sep 18, 2018

What's the state of this project and/or your fork @mgibeau ?

@binarymist I'm currently using the fork in one of our project and aside from the stream implementation, it's working well. I'll look into adding a few more tests and a more complete pipeline as next items. Let me know if you run into issues.

@DABH I'll reach out for the NPM access. Ideally, I'd like to have a pipeline handle this automatically on tagged commits :)

@mgibeau mgibeau merged commit c3b12d7 into winstonjs:master Sep 18, 2018
@yads
Copy link
Contributor

yads commented Sep 18, 2018

There have been several issues open asking for a new NPM release, but glad to see the project still being monitored, that's great news!

@DABH
Copy link
Contributor

DABH commented Sep 18, 2018

Yeah, hopefully with winston@3 becoming more stable now, we can give some new life to all the community transports, let's see :) Asked indexzero regarding npm access so hopefully we see some new npm releases soon.

@mgibeau mgibeau deleted the winston3-redislatest branch September 18, 2018 11:43
@binarymist
Copy link

binarymist commented Sep 18, 2018

Good work contributors!
It looks like the transport doesn't quite fit my requirements of pushing three (at this stage) types of data:

  1. text message (which needs to end up in winston)
  2. integer message as a % (targeting server sent events (SSE))
  3. integer message as a bug count (targeting SSE)

All of which will be sent on three different channels minimum at different times, in the form of:

{ id: update.timestamp, event: update.event, data: update.data }

which is consumed by subscribbers converting the messages into SSEs (AKA EventSource) to be sent to a CLI somewhere on the internet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants