-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some fixes, small features, and running tests #61
Conversation
wmake
Outdated
@@ -50,6 +50,9 @@ _linux_setup() { | |||
exit 1; | |||
fi | |||
|
|||
printf "Initiating submodules...\n" | |||
git submodule update --init |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this not be better git submodule update --init --recursive
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true tm
wmake
Outdated
@@ -84,6 +87,10 @@ _linux_setup() { | |||
printf "Done!\n" | |||
} | |||
|
|||
_avr_setup() { | |||
apt-get install gcc-avr avr-libc avrdude |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also update apt-get
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true tm
@@ -101,6 +101,10 @@ var runFlags = []cli.Flag{ | |||
Name: "port", | |||
Usage: "Specify upload port", | |||
}, | |||
cli.StringFlag{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this but it will be more intuitive for a user to just do wio run arg1 arg2 arg3 arg4
. We have to figure out when targetName is provided to run. Maybe check the first argument and see if it is a valid target and if not use all the args as arguments. Idk we can think about this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But i guess args
ain't that bad to type either so idk lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah but currently it just takes everything as a target (even though you can only run one target...)
it's probably fine for now, really just need it for testing
* wio update no longer copies new files * Fixing removing .wio files * install and extract * avr-setup * travis run tests * Fixing app projects * wio run with args * Reducing size of arduino revisions.txt * fixing bug in c/cpp standards parsing * removed testify from deps * tests for apps with args * Moving ToUpper to go * Fixing tests * removing sudo * before_install * Update wmake * Update wmake
* wio update no longer copies new files * Fixing removing .wio files * install and extract * avr-setup * travis run tests * Fixing app projects * wio run with args * Reducing size of arduino revisions.txt * fixing bug in c/cpp standards parsing * removed testify from deps * tests for apps with args * Moving ToUpper to go * Fixing tests * removing sudo * before_install * Update wmake * Update wmake
No description provided.