Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add conversationId on bot removed event #144

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

yamilmedina
Copy link
Collaborator


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Missing information about which conversation the bot was removed from, making it not possible to clean up resources in a detailed manner, ie, removing data from the bot associated to the conversationId.

Solutions

Adds conversationId information to the onBotRemoved event, so bots can react and perform a cleanup of their resources.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Mar 11, 2024
Copy link

Test Results

8 tests   7 ✔️  7s ⏱️
4 suites  1 💤
4 files    0

Results for commit 1d339af.

@yamilmedina yamilmedina merged commit 0cfb25e into staging Mar 11, 2024
3 checks passed
@yamilmedina yamilmedina deleted the feat/info-for-bot-removed branch March 11, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants