Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate flowrow to compose foundation (WPB-3541) #2082

Merged
merged 7 commits into from Aug 25, 2023

Conversation

trOnk12
Copy link
Contributor

@trOnk12 trOnk12 commented Aug 10, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • With the bump of comopse, we do not need the FlowRow coming from accompanist anymore.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@trOnk12 trOnk12 changed the title chore: migrate flowrow to compose foundation chore: migrate flowrow to compose foundation (WPB-3541) Aug 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

Test Results

583 tests   582 ✔️  6m 55s ⏱️
  84 suites      1 💤
  84 files        0

Results for commit 771cb2f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1013 succeeded.

The build produced the following APK's:

@ohassine
Copy link
Member

Shouldn't we remove accompanist-flowLayout dependency as well ?

@AndroidBob
Copy link
Collaborator

Build 1019 failed.

@AndroidBob
Copy link
Collaborator

Build 1024 failed.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #2082 (6dcd227) into develop (ff0283a) will decrease coverage by 1.51%.
Report is 3 commits behind head on develop.
The diff coverage is n/a.

❗ Current head 6dcd227 differs from pull request most recent head 771cb2f. Consider uploading reports for the commit 771cb2f to get more accurate results

@@              Coverage Diff              @@
##             develop    #2082      +/-   ##
=============================================
- Coverage      40.65%   39.14%   -1.51%     
+ Complexity       981      920      -61     
=============================================
  Files            310      305       -5     
  Lines          11379    11194     -185     
  Branches        1524     1491      -33     
=============================================
- Hits            4626     4382     -244     
- Misses          6314     6390      +76     
+ Partials         439      422      -17     

see 34 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f10ed9...771cb2f. Read the comment docs.

@AndroidBob
Copy link
Collaborator

Build 1068 failed.

@AndroidBob
Copy link
Collaborator

Build 1273 failed.

@ohassine ohassine added this pull request to the merge queue Aug 25, 2023
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 27f2ea3 Aug 25, 2023
11 of 12 checks passed
@ohassine ohassine deleted the chore/migrate_flowrow branch August 25, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants