Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert changes of #2245 #2263

Merged
merged 2 commits into from
Sep 22, 2023
Merged

chore: revert changes of #2245 #2263

merged 2 commits into from
Sep 22, 2023

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

PR #2245 has introduced many new bugs

Solutions

Reverting it

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, yamilmedina, alexandreferris, borichellow, mchenani and saleniuk and removed request for a team September 22, 2023 14:20
@github-actions
Copy link
Contributor

Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit fd5ffeb.

@tmspzz tmspzz enabled auto-merge (squash) September 22, 2023 14:32
@tmspzz tmspzz merged commit c2ed958 into release/candidate Sep 22, 2023
9 of 10 checks passed
@tmspzz tmspzz deleted the revert_changes branch September 22, 2023 14:43
github-actions bot pushed a commit that referenced this pull request Sep 22, 2023
@github-actions github-actions bot mentioned this pull request Sep 22, 2023
6 tasks
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 921 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants