Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(applock): app navigates to biometrics screen after entering passcode RC - cherrypick #2436

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

cherrypick of #2434


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine changed the base branch from develop to release/candidate November 16, 2023 16:31
Copy link
Contributor

Test Results

682 tests  ±0   682 ✔️ ±0   10m 56s ⏱️ + 2m 4s
  98 suites ±0       0 💤 ±0 
  98 files   ±0       0 ±0 

Results for commit 9e24c7f. ± Comparison against base commit 18795b3.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1862 succeeded.

The build produced the following APK's:

@ohassine ohassine enabled auto-merge (squash) November 17, 2023 07:41
@ohassine ohassine merged commit 340255a into release/candidate Nov 17, 2023
10 of 11 checks passed
@ohassine ohassine deleted the fix_biometrics_screen_rc branch November 17, 2023 07:57
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1870 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants