Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove test conversation emit sequence #336

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Conversation

trOnk12
Copy link
Contributor

@trOnk12 trOnk12 commented Jan 28, 2022


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

-remove the test emitting the sequence of list of conversation items


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@CLAassistant
Copy link

CLAassistant commented Jan 28, 2022

CLA assistant check
All committers have signed the CLA.

@trOnk12 trOnk12 merged commit 000fc16 into develop Jan 28, 2022
@trOnk12 trOnk12 deleted the fix/remove_test branch January 28, 2022 11:34
@github-actions
Copy link
Contributor

Unit Test Results

1 files  1 suites   0s ⏱️
7 tests 7 ✔️ 0 💤 0

Results for commit f083871.

tmspzz pushed a commit that referenced this pull request Jan 28, 2022
Co-authored-by: mateusz.pachulski <mateusz.pachulski@appunite.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants