fix: Correctly detect if current device is MLS capable #6185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
commented
Apr 30, 2024
| @@ -620,7 +627,7 @@ export class Account extends TypedEventEmitter<Events> { | |||
| }); | |||
|
|
|||
| const handleMissedNotifications = async (notificationId: string) => { | |||
| if (this.service?.mls) { | |||
There was a problem hiding this comment.
now, the fact that the mls service is instantiated doesn't necesarily means the mls device is ready to use. We need to add some more checks before doing any kind of mls operation.
This is due to the fact that we do not yet have the MLS config when the core is instantiated. So we cannot decide whether the MLS service should be instantiated at build time. Thus we need some extra checks
V-Gira
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the consumer to know if an MLS device has been setup or not.
This is to prevent trying to do MLS operations if the devices has not been initialized