Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: legal hold modal styling issues #17604

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

PatrykBuniX
Copy link
Contributor

Description

Fixes some styling issues with legal hold modal.

Screenshots/Screencast (for UI changes)

Before:
Outilne cut off:
Screenshot 2024-06-18 at 12 16 39
Back arrow misplaced and extra padding in the devices list:
Screenshot 2024-06-18 at 12 35 51

Now:
Outline is in place (used margin instead of internal padding)
Screenshot 2024-06-18 at 12 16 23
Arrow is in place and extra padding got removed
Screenshot 2024-06-18 at 12 35 25

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.14%. Comparing base (cb4d5e8) to head (5bba3aa).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #17604      +/-   ##
==========================================
- Coverage   46.14%   46.14%   -0.01%     
==========================================
  Files         760      760              
  Lines       25012    25012              
  Branches     5724     5724              
==========================================
- Hits        11542    11541       -1     
- Misses      12027    12028       +1     
  Partials     1443     1443              

@PatrykBuniX PatrykBuniX merged commit e71004f into dev Jun 18, 2024
11 checks passed
@PatrykBuniX PatrykBuniX deleted the runfix/legal-hold-styling-issues branch June 18, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants