fix(actions): prevent command injection in GHA workflow (WPB-9709) #17620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otto-the-bot
added
type: bug / fix 🐞
comp: infrastructure
👕 size: XS
👕 size: S
and removed
👕 size: XS
labels
|
lwille
force-pushed
the
WPB-9709-fix-gha-cmd-injection
branch
2 times, most recently
from
7268ced
to
1dae6e7
Compare
lwille
added
security
It was possible to run arbitrary commands in the context of the GitHub Actions workflow by using an unsanitized user input (`env`) in a run step. As a best practice, we shall try to sanitize any user input. related to WPB-9709
lwille
force-pushed
the
WPB-9709-fix-gha-cmd-injection
branch
from
1dae6e7
to
fbf3b16
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #17620 +/- ##
==========================================
+ Coverage 46.58% 46.59% +0.01%
==========================================
Files 781 781
Lines 25158 25161 +3
Branches 5753 5756 +3
==========================================
+ Hits 11719 11723 +4
Misses 11964 11964
+ Partials 1475 1474 -1 |
tlebon
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was possible to run arbitrary commands in the context of the GitHub Actions workflow by using an unsanitized user input (
env) in a run step.As a best practice, we shall try to sanitize any user input, which can be done by passing it through an env var.
References
Checklist