Don't confirm branch status when release_label configured
#65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least once every couple weeks I think I released some code via `git release` and come back to my console hours later (or the next day) to find it sitting on the `Branch status is currently: pending. Proceed with release? (y/n)` prompt. This prompt is really helpful when there isn't too much churn on the main branch, but with high churn it's likely to show up a lot more often. Moreover, it's less important when using a merge tool via `release_label` because `gitx` isn't merging the code directly and the merge tool will presumably be confirming the build status before merging the code. This seemed like a pragmatic (if not a little magic) change. I could see an alternative to this being the ability to suppress the prompt via a separate config variable instead of automatically when `release_label` is used.
Merged
wireframe
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least once every couple weeks I think I released some code via
git releaseand come back to my console hours later (or the next day) to find it sitting on theBranch status is currently: pending. Proceed with release? (y/n)prompt.This prompt is really helpful when there isn't too much churn on the main branch, but with high churn it's likely to show up a lot more often. Moreover, it's less important when using a merge tool via
release_labelbecausegitxisn't merging the code directly and the merge tool will presumably be confirming the build status before merging the code.This seemed like a pragmatic (if not a little magic) change. I could see an alternative to this being the ability to suppress the prompt via a separate config variable instead of automatically when
release_labelis used. Let me know if you'd like to see that (or something else) instead.