Skip to content

Conversation

nahuel11500
Copy link
Contributor

No description provided.

@nahuel11500 nahuel11500 force-pushed the feat/add-dry-run-and-fix-notion-block-generating branch from d3a5c47 to c8752ab Compare September 24, 2025 11:54
@nahuel11500 nahuel11500 requested a review from Copilot September 24, 2025 11:56
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for output file option in dry-run mode and improves error handling. The main purpose is to enhance the dry-run functionality by allowing users to save the generated JSON to a file instead of only printing to stdout, while also making the tool more robust in dry-run scenarios by relaxing validation requirements.

Key changes:

  • Added OutputFile configuration option for writing dry-run output to a file
  • Improved dry-run mode by skipping Notion API client initialization and validation when not needed
  • Enhanced table support with proper Notion API table block structures
  • Better error handling and progress reporting for block operations

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
internal/run/run.go Added OutputFile config field, improved dry-run validation logic, and enhanced block deletion progress reporting
internal/notion/types.go Extended Block type with table support and improved JSON serialization
internal/notion/client.go Reduced chunk size for better reliability with large documents
internal/markdown/convert.go Added comprehensive table conversion support and improved image URL validation
cmd/notion-md/main.go Added output-file flag and updated help text for dry-run usage
README.md Updated command examples and documentation to reflect new features

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nahuel11500 nahuel11500 merged commit 242bfac into main Sep 24, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant