Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments immediately following an input/output without a type do not preprocess correctly #2465

Closed
marchcain opened this issue Oct 29, 2022 · 0 comments
Closed

Comments immediately following an input/output without a type do not preprocess correctly #2465

marchcain opened this issue Oct 29, 2022 · 0 comments
Labels
Bug E2

Comments

@marchcain
Copy link
Contributor

Describe the bug
When typing a comment without a space inbetween a variable that does not specify its type and the comment itself, the preprocessor confuses the comment as part of the variable name, throwing an invalid character error. This does not happen with persisted variables, only input/outputs.

To Reproduce

@inputs Test#comment
^^^ won't validate

@inputs Test #comment
^^^ will validate

Expected behavior
Comments are properly filtered out and Test#comment would validate

Screenshots

gmod_ydZfNEgIPW
Vurv78 added a commit to Vurv78/wire that referenced this issue Oct 29, 2022
@Vurv78
Fix wiremod#2465
f870c29
@Vurv78 Vurv78 closed this as completed in 6e9eee4 Nov 1, 2022
Vurv78 added a commit to Vurv78/wire that referenced this issue Nov 15, 2022
@Vurv78
E2 Fixes
7734f5f 
* Fix wiremod#2481 and add regression test
* Fix wiremod#2486 by refactoring `->` and `~` operators to use GetVariableType
* Add regression test for wiremod#2465 I missed
@Vurv78 Vurv78 mentioned this issue Nov 15, 2022
Merged
Vurv78 added a commit that referenced this issue Nov 16, 2022
@Vurv78
E2 Fixes (#2488)
d781166 
* Fix #2481 and add regression test
* Fix #2486 by refactoring `->` and `~` operators to use GetVariableType
* Add regression test for #2465 I missed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug E2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marchcain @Vurv78