Fix wirelinks getting removed by WireLib.AdjustOutputs #2314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behavior is inconsistent as existing wires are preserved through an adjustment, but wirelinks are not.
When calling
WireLib.AdjustOutputs(entity, nameList)
,wirelink
is not passed. If it were, it'd show up whether an actual wirelink existed or not. It would also be created asNORMAL
and notWIRELINK
, blocking any attempts to create an actual wirelink.Proposed fix here just adds
wirelink
andWIRELINK
tonames
andtypes
if one exists to preserve the wirelink.