-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2 Permissions Escalation Fix and @disabled
rework
#2443
Conversation
Reimplement changing owner on code upload Add `@disabled` when pasting a duped E2 with 3rd party code Remove now unused friendwrite convar Use new `@disabled` functionality for duped chips with compile errors
@Anticept should the world overlay even display the CPPI owner? All prop protection addons I've used have some form of HUD overlay already |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Part of the reason I suggest this is to communicate to everyone that it is possible for the owner of a chip, and the owner of the code that runs on the chip, to be different. Thus this helps people understand what might be going on. As it stands right now, nothing does this in wiremod, so it's a paradigm shift. If someone uploads code to an E2, certain things might act on them instead of the chip owner right? Prop protection or not, this is another way to help people understand what is going on. So yes, please include showing on the world overlay. |
One other thing, I'm going to rename @Vurv78 has informed me of preprocessor commands, which are a better fit for this than directives |
Just tested in multiplayer, all works |
Replaced This also allows for easy addition of |
Display CPPI owner when available on base wire entity overlay
Tested the UI in singleplayer and multiplayer both with and without CPPI implementing addons |
This reimplements my original perms escalation fix from last year, and improves upon
@disabled
by turning it into a preprocessor form oferror()
.It also adds the directive when an E2 is pasted from a dupe that has code authored by someone other than the player duplicating.
Additionally, I saw that
:SetPlayer()
wasn't being called from theWire_Expression2_Player_Authed
hook while I was searching for all instances of settingchip.player
so I've added a call to it there.Still a draft as I need to implement the two owners into both the tooltip and remote uploader, and I need to test the dupe protection in multiplayer