Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2 function e:velAtPoint(v) #2444

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Add E2 function e:velAtPoint(v) #2444

merged 2 commits into from
Oct 11, 2022

Conversation

CheezusChrust
Copy link
Contributor

@Vurv78
Copy link
Contributor

Vurv78 commented Oct 10, 2022

Looks good, name is a bit questionable but it fits with the rest of the methods, so...

Could also add [nodiscard] if you want on top of the e2function since this is a getter

@CheezusChrust
Copy link
Contributor Author

Yeah, I would've named it better however I wanted it to be consistent with the other velocity methods.

@Vurv78 Vurv78 merged commit 7dc9f10 into wiremod:master Oct 11, 2022
@CheezusChrust CheezusChrust deleted the add-velAtPoint-e2func branch October 12, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegrb93 thegrb93 thegrb93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CheezusChrust @Vurv78 @thegrb93