Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend validation menu #2453

Merged
merged 7 commits into from
Oct 20, 2022
Merged

Extend validation menu #2453

merged 7 commits into from
Oct 20, 2022

Conversation

marchcain
Copy link
Contributor

Replaces the previous validation button with a collapsible and scalable problems menu. This should make viewing multiple warnings at once significantly less painful to deal with. It also allows for multiple errors to be shown in the E2 editor if this is ever implemented. This implements my idea in #2392 and has also been made compatible with the other editors (CPU's, etc)

I had the idea to fully utilize the tree view and show every problem within every open file, but I chose not to implement that for now. May make this into another PR later down the road.

WarningPanel

Copy link
Contributor

@Vurv78 Vurv78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works for e2/cpu for me. Just a nitpick with color creation in a render hook

lua/wire/client/text_editor/issue_viewer.lua Outdated Show resolved Hide resolved
@Fasteroid
Copy link
Contributor

this looks hot

@Fasteroid
Copy link
Contributor

please merge this it is literally the sex

@Vurv78 Vurv78 merged commit 147b817 into wiremod:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants