Add effectCanPlay(void) and effectCanPlay(s)
#2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonsturgeon
approved these changes
Nov 1, 2022
| e2function number effectCanPlay(string name) | ||
| if not isAllowed(self) then return 0 end | ||
| if effect_blacklist[name] then return 0 end | ||
| if hook.Run( "Expression2_CanEffect", name:lower(), self ) == false then return 0 end |
There was a problem hiding this comment.
Is this / should this be documented somewhere?
There was a problem hiding this comment.
I didn't add it, just parity with the old function that already had that function call.
da4eff1
Looks like it was already an undocumented list, now just an undocumented hook. Either way this would only really be relevant to developers specifically looking to block E2's effects, so they could just check the source of the function and find this hook.
Could maybe in the future compile these hooks into a wiki page
There was a problem hiding this comment.
Cool, sounds good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2411