Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render-Target Camera and Screen fixes #2576

Merged
merged 5 commits into from
May 24, 2023
Merged

Render-Target Camera and Screen fixes #2576

merged 5 commits into from
May 24, 2023

Conversation

stepa2
Copy link
Contributor

@stepa2 stepa2 commented May 21, 2023

  • Fixes broken RT Screen material variants dropdown
  • Fixes RT Camera darkening when halos are rendered
  • Fixed some cases when last frame from disabled RT Camera are shown

Halo fix detours Garry's mod hook for drawing halos. Proper PR to garrysmod repo needed.

thegrb93
thegrb93 requested changes May 22, 2023
View reviewed changes
lua/wire/client/cl_wirelib.lua Outdated Show resolved Hide resolved
@stepa2
Copy link
Contributor Author

stepa2 commented May 23, 2023

Are you waiting for me to finish #2578 before merging this PR and #2577?

@thegrb93
Copy link
Contributor

No, just giving other reviewers a chance to look

@thegrb93 thegrb93 merged commit 9d0c146 into wiremod:master May 24, 2023
@stepa2 stepa2 deleted the pr-rtfix branch May 24, 2023 09:42
@Aws0mee
Copy link
Contributor

Aws0mee commented May 24, 2023

@stepa2 does this PR fix this?
image

@stepa2 stepa2 mentioned this pull request May 27, 2023
Merged
@Vurv78 Vurv78 mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegrb93 thegrb93 thegrb93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stepa2 @thegrb93 @Aws0mee