Minor bone and ragdoll E2 fixes #2896
Conversation
Fix ragdollSetPose(table, number) with 0 would not rotate properly
Add dynamic perf
| local bone_count = entity:GetPhysicsObjectCount() | ||
| if table.Count(entity2bone[entity] or {}) ~= bone_count then |
There was a problem hiding this comment.
Are an entity's bones count able to change? I'm not sure what this fixes.
There was a problem hiding this comment.
entity2bone[entity] exists when you get only 1 bone, so this assumes the array is full. Not sure how to do this elegantly.
There was a problem hiding this comment.
Make it so getting 1 bone populates the whole array.
There was a problem hiding this comment.
Or make it so getting 1 bone doesn't use the cache.
| end | ||
|
|
||
| pose.size = #pose.n | ||
| pose.stypes._origina = "a" | ||
| pose.s._origina = bones[0]:GetAngles() |
There was a problem hiding this comment.
Do E2 arrays support 0 index?
There was a problem hiding this comment.
Also should _origina be documented
There was a problem hiding this comment.
They can use them but they won't work on foreach. This is a table anyway. Numerical indices are already being used for the bones themselves.
There was a problem hiding this comment.
Also should _origina be documented
It's kind of an internal thing but I guess I could. Somewhere.
|
@Denneisk sorry, my review comments I added a few weeks ago never got submitted somehow lol |
|
tl;dr, I don't like the table.Count, I think the cache needs to be a little smarter |
ragdollSetPosebased on sizeE2Lib.GetBoneswould not fill empty keys in bone tableragdollSetPose(table, number)with 0 would not rotate to the correct target angle