printColor rewrite
#2937
Merged
printColor rewrite
#2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add: - Dynamic perf on printColor (1 op per bit sent) - ConVar to disable warnings on printColor Change: - Rewrote printColor - printColor now uses modified normal print max length to limit - Print max length now use server's maxlength in singleplayer - printColor warning now fires only once per session
|
Heh sorry thought the labels would be cool |
thegrb93
reviewed
Dec 23, 2023
Comment on lines
27
to
29
| local head = net.ReadUInt(4) | ||
| if head == 0 then break end | ||
| msg[i] = printcolor_readers[head]() |
There was a problem hiding this comment.
This might be safer from lua errors
local reader = printcolor_readers[net.ReadUInt(4)]
if not reader then break end
msg[i] = reader()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add:
printColor(1 op per bit sent)printColorChange:
printColorto be faster and more robustprintColornow uses modified normal print max length to limitprintColorwarning now fires only once per sessionprintColorwarning does not appear for your own E2s (? Maybe controversial)