Prevent CD error on attempting to disable the CD's Lock #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Denneisk
approved these changes
Dec 28, 2023
Vurv78
previously requested changes
Dec 28, 2023
lua/entities/gmod_wire_cd_lock.lua
Outdated
| @@ -97,7 +97,9 @@ function ENT:AttachDisk(disk) | |||
|
|
|||
| self.Const:CallOnRemove("wire_cd_remove_on_weld",function() | |||
| self.Const = nil | |||
| self.Disk.Lock = nil | |||
| if(IsValid(self.Disk)) then | |||
There was a problem hiding this comment.
Redundant parens, also it doesn't need to be valid but w/e
There was a problem hiding this comment.
Was following the isvalid check on file line 61, which I'd believed to be in the primary style of the rest of the file but it turns out it's just wildly inconsistent throughout the file anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disabling a CD Lock with the "Disable" wire input while it's holding a CD, it will cause an error due to attempting to index an entity/table that doesn't exist.
This will check if the disk exists on self before attempting to remove the lock on it, preventing the error.