Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spawnmenu icon location / fileformat #2980

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

wrefgtzweve
Copy link
Contributor

@wrefgtzweve wrefgtzweve commented Jan 17, 2024

Gmods default spawn icons are in materials/entities/classname.png this pr fixes the paths to prevent lag / console warnings due to gmod having to check multiple locations

image

To test it, simply run developer 1
Be on main branch, open the spawnmenu and go to the wiremod category in weapons and entities.

@thegrb93
Copy link
Contributor

No remote controller?

@wrefgtzweve
Copy link
Contributor Author

wrefgtzweve commented Jan 18, 2024

Remote controller doesn't have an image at all, so that'd always be missing, I was thinking of adding one but i find a good image for it.

@thegrb93
Copy link
Contributor

Png images take a lot longer to load than vtf. I'm not sure this is actually solving anything or making anything faster.

@wrefgtzweve
Copy link
Contributor Author

wrefgtzweve commented Jan 18, 2024

They don't
If you want examples, try m9k and open the weapons tab you'll receive a significiant freeze, doing the same once all vtfs are converted to pngs loads them with no lag spike whatsoever. If you want i can help you replicate it.

@brandonsturgeon
Copy link
Contributor

Just my 2 cents:

Removing the console warning is reason enough to change it up.
Given that it's only two images, I think the performance difference is negligible.

@thegrb93 thegrb93 merged commit da33312 into wiremod:master Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants