Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v0.4 release #338

Closed
wants to merge 92 commits into from
Closed

Prepare v0.4 release #338

wants to merge 92 commits into from

Conversation

formatc1702
Copy link
Collaborator

@formatc1702 formatc1702 commented May 5, 2024

See #339 instead.

formatc1702 and others added 30 commits October 11, 2021 22:08
`.gv` and `.html` files include the version number as a comment.
Rebuild to avoid diffs during development
Moved metadata and options info further down, so that the core functionality (connectors, cables, connection sets) comes first.
- Use pin names instead of pin indices, until the last moment when generating the ports for the GraphViz nodes
- `Harness.add_mate_pin()` now uses pin names
- Remove unused `if is_arrow()` check from `Harness.connect()`
- Consolidate calling of `Connector.activate_pin()` to prevent subtle bugs
  - Call it from `connect()` and `add_mate_pin()`
  - No longer call it from `create_graph()`
- Misc. other tuning
Co-authored-by: kvid <kvid@users.noreply.github.com>
Co-authored-by: kvid <kvid@users.noreply.github.com>
Co-authored-by: kvid <kvid@users.noreply.github.com>
Co-authored-by: kvid <kvid@users.noreply.github.com>
Experiments in exporting PDF using `wkhtmltopdf` utility caused borders to disappear when set to 0.25mm, but 0.35mm renders fine
Re-add `parse_file()` for building examples

bla
formatc1702 and others added 26 commits June 7, 2023 19:26
The two header comments were missing trailing newlines.

This behavior is introduced by v0.18 of the graphviz Python package;
where as v0.17 did include the newline automatically.

Closes #258
Changes in #186 made it impossible to hide cable wire numbers.

#186 (comment)
Hard-coding OS error numbers that differ between different platforms
caused the program to crash at platforms using a different error number.

Using the Standard errno system symbols will avoid this problem.

Co-authored-by: kvid <kvid@users.noreply.github.com>
- Resolves #263 that describes warnings and weird loop drawing because
  loop connected pins are hidden when hide_disconnected_pins=True.

- Activate loop pins as early as possible to enable correct counting of
  connected pins when
  connector.additional_components.qty_multiplier=populated.

- Check that loop pins actually exist before activating them.
No need to reference github issue in the code.

Co-authored-by: Daniel Rojas <github@danielrojas.net>
Add two more folders to be ignored.

- .idea: Used by PyCharm
- .venv: My convention for creating virtualenvs
Co-authored-by: kvid <kvid@users.noreply.github.com>
@formatc1702 formatc1702 requested a review from kvid May 5, 2024 12:49
@formatc1702 formatc1702 closed this May 5, 2024
@formatc1702 formatc1702 removed the request for review from kvid May 5, 2024 13:15
@formatc1702 formatc1702 deleted the release/v0.4-rc branch May 12, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants