Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate @withso/pop-media-sdk to allow different media providers #12

Merged
merged 2 commits into from
May 19, 2022

Conversation

a-type
Copy link
Contributor

@a-type a-type commented May 19, 2022

This PR replaces PopSpace's old media setup (with hardcoded Twilio) and uses @withso/pop-media-sdk and associated packages instead, allowing the app to utilize either Twilio or LiveKit as the backing media provider.

To use Twilio, you must provide the environment variable REACT_APP_USE_TWILIO=true along with the existing Twilio environment variables.

To use LiveKit, provide REACT_APP_USE_LIVEKIT=true instead, and add the required config variables:

# required for the noodle-app package (React app)
REACT_APP_LIVEKIT_ENDPOINT=https://your-livekit-endpoint.com
# required for the noodle-api package (the HTTP API)
LIVEKIT_API_KEY=your-livekit-api-key
LIVEKIT_SECRET_KEY=your-livekit-secret-key

@a-type a-type merged commit 734aacb into main May 19, 2022
@a-type a-type deleted the media-sdk branch May 19, 2022 16:21
@lobau lobau mentioned this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant