Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Vite to 6.0.0 #12524

Merged
merged 13 commits into from
Nov 27, 2024
Merged

Update Vite to 6.0.0 #12524

merged 13 commits into from
Nov 27, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 25, 2024 •
edited
Loading

Changes

  • Update Vite to 6.0.0
  • Handle breaking change in Astro
  • Update vite-plugin-svelte and vite-plugin-solid to handle vite 6

Testing

CI should pass

Docs

n/a

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: bab3dd1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: example Related to an example package (scope) pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) semver: major Change triggers a `major` release labels Nov 25, 2024
github-actions[bot]
github-actions bot requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

@bluwy bluwy marked this pull request as draft November 25, 2024 16:04
@bluwy bluwy changed the title Update Vite to 6.0.0-beta.10 Update Vite to 6.0.0 Nov 26, 2024
@bluwy
Copy link
Member Author

bluwy commented Nov 26, 2024

CI fails should be fixed by vitejs/vite#18784

@bluwy bluwy marked this pull request as ready for review November 27, 2024 05:14
ematipico
ematipico approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit around a changeset. We can merge it :)

.changeset/breezy-brooms-count.md Outdated Show resolved Hide resolved
@bluwy @ematipico
Update .changeset/breezy-brooms-count.md [skip-ci]
bab3dd1 
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
@bluwy bluwy merged commit 9f44019 into next Nov 27, 2024
14 checks passed
@bluwy bluwy deleted the vite-beta-10 branch November 27, 2024 10:00
@astrobot-houston astrobot-houston mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] requested changes

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) semver: major Change triggers a `major` release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluwy @ematipico