Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(fr): Update some files for the week n°12 #7493

Merged
merged 22 commits into from
Mar 24, 2024
Merged

i18n(fr): Update some files for the week n°12 #7493

merged 22 commits into from
Mar 24, 2024

Conversation

thomasbnt
Copy link
Member

@thomasbnt thomasbnt commented Mar 19, 2024 •
edited
Loading

Description (required)

Update some files in French language. Please, merge week 11 before #7289 ⚠️ merged!

Related issues & labels (optional)

  • Suggested label: I18n

thomasbnt added 12 commits March 20, 2024 00:05
@thomasbnt
i18n(fr): Add one link for Astro DB, from withastro@209b013
6d097a0 
Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
@thomasbnt
i18n(fr): Add one link about Astro DB, from withastro@54ec7f2
5aaed91 
Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
@thomasbnt
i18n(fr): Update authentification.mdx "astro-auth" -> "auth-astro", f…
a5f509a 
…rom withastro@7e14ad5

Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
@thomasbnt
i18n(fr): Update butterCMS.mdx with adding one link, from withastro@a…
fce2cac 
…133dc2

Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
@thomasbnt
i18n(fr): Fix typo in buttercms.mdx
485f50a 
Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
@thomasbnt
i18n(fr): Update strapi.mdx 💜 with adding <li>, from withastro@51879ce
415cc04 
Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
@thomasbnt
i18n(fr): fix typo in content-collection-type-mismatch-error.mdx
11c697e 
Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
@thomasbnt
i18n(fr): Update content-collections.mdx about absolute URL, from wit…
b0b7a77 
…hastro@5e4c7dd

Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
@thomasbnt
i18n(fr): Update cloudflare.mdx from withastro@52864bc
554ba15 
Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
@thomasbnt
i18n(fr): Update integration-guide/cloudflare.mdx from withastro@52864bc
3a022c8 


Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
@thomasbnt
i18n(fr): Update add-content-collections.mdx with <Steps>, from witha…
4439ee3 
…stro@d62420e

Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
@thomasbnt
i18n(fr): Update add-view-transitions.mdx with <Steps>, from withastro@…
0b40186 
…88711e6

Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Mar 19, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Mar 24, 2024 5:21pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Mar 24, 2024 5:21pm

@thomasbnt
i18n(fr): Fix link
04259a4 
Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
@liruifengv
Copy link
Member

Thanks for your work. I think splitting into multiple smaller PRs would be a bit better for review and quick merges

dreyfus92
dreyfus92 reviewed Mar 20, 2024
View reviewed changes
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coucou @thomasbnt 😁, je ne suis pas sûr de ce qui pourrait causer l'échec du CI/CD. Nous pourrions supprimer la mise à jour du fichier add-view-transitionts.mdx et ouvrir un nouveau PR pour gérer la mise à jour indépendamment.

@thomasbnt
Copy link
Member Author

Coucou @thomasbnt 😁, je ne suis pas sûr de ce qui pourrait causer l'échec du CI/CD. Nous pourrions supprimer la mise à jour du fichier add-view-transitionts.mdx et ouvrir un nouveau PR pour gérer la mise à jour indépendamment.

Salut @dreyfus92, je vais faire ça !
Hello @liruifengv, It would take me a lot longer to do each file, especially when there are several of them. I wouldn't mind that per se, but for small modifications, I figure I might as well group them all together.

@thomasbnt
i18n(fr): Fix link
aab9502 
Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
@vercel Vercel
Copy link

vercel bot commented Mar 20, 2024

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@thomasbnt
Copy link
Member Author

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

Wut??

@thomasbnt
Copy link
Member Author

Can be merged!

dreyfus92
dreyfus92 approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci @thomasbnt, LGTM ✅

@dreyfus92 dreyfus92 merged commit 4cf5ac5 into withastro:main Mar 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreyfus92 dreyfus92 dreyfus92 approved these changes

Assignees
No one assigned
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasbnt @liruifengv @dreyfus92