fix(syntax): Apply JSX latest rules for our language #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9092769 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Test failure is unrelated to the change (the test it's trying to run but failing doesn't test this), not sure what's happening |
|
Oh, it's a Node change nodejs/node#52554 |
matthewp
approved these changes
Apr 23, 2024
natemoo-re
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add a few more things from TSX's syntax to our rules that are not inherited due to a VS Code bug.
Fixes #713 and a few unreported issues (ex:
>>>=wasn't properly highlightedTesting
Tested manually, you can't test this inside grammar tests because you don't see the underlying language being applied, just the
source.tsxscope.Docs
N/A