Normalize locale input format before matching, fix #3 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Repace `-` with `_` - Capitalize characters after `_`
| @@ -60,6 +60,14 @@ const localesToNonStandardFacebookLocales = _(facebookVirtualLocales) | |||
| .value() | |||
|
|
|||
| export const bestFacebookLocaleFor = locale => { | |||
| // Normalize locale input format | |||
| if (locale.includes('-')) { | |||
There was a problem hiding this comment.
The if (locale.includes('-')) { check is moot for this as replace is a noop if there's no - in the string.
There was a problem hiding this comment.
I treat this just about kind of style, I know the results is totally the same :)
| locale = locale.replace('-', '_'); | ||
| } | ||
| if (locale.includes('_')) { | ||
| locale = locale.split('_')[0] + '_' + locale.split('_')[1].toUpperCase(); |
There was a problem hiding this comment.
This can be written more readable:
const [language, territory] = locale.split('_');
locale = `${language}_${territory.toUpperCase()}`;There was a problem hiding this comment.
I'm not sure which style is more acceptable, would like to wait for review from its maintainer.
|
@dleshem do you mind to help review this PR? Thanks! |
|
@PeterDaveHello Sorry, I no longer work in Wix... |
Sorry, didn't notice that 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-with__Original results looks odd in some situations:
The corrected results would be as fellow: