Remove lodash

[cesine]

Smaller bundle size

We noticed our bundle is importing lodash (23.99 gzipped) because it facebook-locales is importing the entirety of lodash as _. This is an older pattern which impacts bundle size for consumers of this repo.

What we would prefer instead, would be for facebook-locales' usage of lodash to fall into the other lodash usages in our bundle which is tree shaken down to (4.29 gzipped)

Options

A straightforward solution is change the imports to:

import map from 'lodash/map';
...

When I looked into the code, I saw that the majority of the usages are simple functions which are now available on array. Given that array functions are now supported in most browsers (and are polly filled for those who are building for non-modern browsers) now is a good time to migrate from lodash to native functions.

• So rather than replacing them with a treeshakable import, I replaced the lodash usage with the array function equivalents.

How this was tested

$ npm test

> facebook-locales@1.0.2 test  facebook-locales
> mocha --compilers js:babel-register



  FacebookLocales
    ✓ supports the default locale: English (United States)
    ✓ supports a standard locale: French (France)
    ✓ supports a non-standard locale: Spanish (Latin America)
    ✓ supports a non-standard locale: Arabic
    ✓ makes best effort to return a supported Facebook locale with the same langauge as an unsupported locale
    ✓ falls back to English (United States) if all else fails


  6 passing (166ms)

$ npm run compile

> facebook-locales@1.0.2 compile facebook-locales
> babel -d dist/ src/

src/Facebook.js -> dist/Facebook.js
src/FacebookLocales.js -> dist/FacebookLocales.js
src/index.js -> dist/index.js