Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for disabling touch indicators through launch argument #751

Closed
wants to merge 2 commits into from

Conversation

LeoNatan
Copy link
Contributor

Closes #640

TODO: JS support

@LeoNatan
Copy link
Contributor Author

@Gongreg

@stale
Copy link

stale bot commented Jul 8, 2018

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@haswalt
Copy link
Contributor

haswalt commented Jul 22, 2018

@l3lik @Gongreg any help required to finish this off? We love using Detox and are working with it to replace fastlane entirely. This is the (almost) last piece to be able to use detox to handle our app store submission process

@LeoNatan
Copy link
Contributor Author

Reminder @Gongreg

@LeoNatan
Copy link
Contributor Author

@haswalt Are you still willing to help? We just need an additional input param to be passed as a launch argument for iOS.

@haswalt
Copy link
Contributor

haswalt commented Aug 21, 2018

@LeoNatan Sure. I'll have a look at this tomorrow.

@LeoNatan
Copy link
Contributor Author

Thanks!

@haswalt
Copy link
Contributor

haswalt commented Aug 21, 2018

@LeoNatan Is there a relatively painless way to get my fork of detox running in a project?

@LeoNatan
Copy link
Contributor Author

Closing in favor of #899

@LeoNatan LeoNatan closed this Aug 23, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 26, 2018
@LeoNatan LeoNatan deleted the DisableTouchIndicators branch July 22, 2019 02:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants