Add support for disabling touch indicators with launch args #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoNatan
suggested changes
Aug 23, 2018
| @@ -335,7 +335,7 @@ - (void)applicationWillEnterForeground:(UIApplication *)application | |||
|
|
|||
| - (BOOL)touchVisualizerWindowShouldAlwaysShowFingertip:(COSTouchVisualizerWindow *)window | |||
| { | |||
| return YES; | |||
| return ![[NSUserDefaults standardUserDefaults] objectForKey:@"detoxDisableTouchIndicators"]; | |||
There was a problem hiding this comment.
Let's not read from the user defaults for every touch.
Please take my changes from https://github.com/wix/detox/pull/751/files
detox/src/devices/Device.test.js
Outdated
| @@ -182,6 +182,15 @@ describe('Device', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it(`relaunchApp() with disableTouchIndicators should send a boolean switch as a param in launchParams`, async () => { | |||
| device = await validDevice(); | |||
| await device.relaunchApp({disableTouchIndicators: true}); | |||
There was a problem hiding this comment.
relaunchApp is deprecated API. Can you please change it to launchApp?
|
Fantastic, thank you! |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #640
Replaces: #751
@LeoNatan