Style Guide Proposal #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliesbot
requested review from
Robfz,
bit-dragon,
jfer-rubio and
sergelerator
jfer-rubio
approved these changes
Apr 3, 2017
index.js
Outdated
| ], | ||
| "rules": { | ||
| "comma-dangle": ["error", "always-multiline"], | ||
| "indent": ["error", 2, { "SwitchCase": 1 }], |
sergelerator
reviewed
Apr 3, 2017
index.js
Outdated
| "react" | ||
| ], | ||
| "rules": { | ||
| "comma-dangle": ["error", "always-multiline"], |
There was a problem hiding this comment.
You are not following this rule in this file 😛
bit-dragon
suggested changes
Apr 3, 2017
sergelerator
reviewed
Apr 3, 2017
index.js
Outdated
| "browser": true, | ||
| "es6": true, | ||
| "mocha": true, | ||
| "node": true |
There was a problem hiding this comment.
Is it fine if some of these are mutually exclusive? i.e. "browser" and "node" will never be true at the same time, right?
There was a problem hiding this comment.
thinking about more use cases, it could be split into several configs, using a main one as a parent, like https://github.com/segmentio/eslint-config
Im not sure if those flags were added considering those cases. If not, I can remove the unused ones.
|
This is also a good opportunity to set additional rules :) Like: https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/prefer-stateless-function.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to unify all the eslint rules in one place, so we can have an standard between projects.
As we're adding rules from time to time to each project, it would be great to do the change in one place, and more important, to have a way to discuss these rule as needed.
This first iteration doesn't consider the use of flow as an standard plugin.
The way it will be used in each project: