Skip to content

Bugfix/v3 misconfiguration fix #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2018
Merged

Bugfix/v3 misconfiguration fix #14

merged 2 commits into from
May 21, 2018

Conversation

rguinea
Copy link
Contributor

@rguinea rguinea commented May 21, 2018

What does this PR do?

Two fixes:

  • (Major) Some extensions were listed as plugins and eslint would never find those modules
  • (Minor) Browser env variable now only set on browser configuration

@rguinea rguinea requested a review from charliesbot May 21, 2018 00:38
@rguinea rguinea merged commit cb7814f into master May 21, 2018
@rguinea rguinea deleted the bugfix/v3-misconfiguration-fix branch May 21, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@charliesbot charliesbot charliesbot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rguinea @charliesbot