Remove unused ValueFormatterStore #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
It has conflicts, just FYI :) |
thiemowmde
force-pushed
the
deadClass
branch
2 times, most recently
from
b03b81e to
29b718e
Compare
thiemowmde
force-pushed
the
deadClass
branch
2 times, most recently
from
ae26eec to
9cb38d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a resubmission of #93 without the bits it removes from the still used ValueFormatter class. This is supposed to make reviewing this much easier because #112 focuses on a single class that is not used any more for sure. I will rebase #93 after #112 is merged.
Bug: T172916