Skip to content

Make unused GlobeCoordinate.getDecimal private #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2017
Merged

Make unused GlobeCoordinate.getDecimal private #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/globeCoordinate/globeCoordinate.GlobeCoordinate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@
this._longitude = gcDef.longitude;
this._precision = gcDef.precision || null;

// TODO: Capture altitude and globe

// TODO: Implement globe specific restrictions. The restrictions below
// allow coordinates for Mars and other globes.
if( Math.abs( this._latitude ) > 360 ) {
Expand All @@ -44,6 +42,9 @@
this._globe = gcDef.globe || 'http://www.wikidata.org/entity/Q2';
};

/**
* @class globeCoordinate.GlobeCoordinate
*/
SELF.prototype = {
// Don't forget about "constructor" since we are overwriting the whole prototype here:
constructor: SELF,
Expand Down Expand Up @@ -107,9 +108,8 @@
getPrecision: function() { return this._precision; },

/**
* Returns an object with decimal latitude, longitude and precision.
*
* @return {Object}
* @private
*/
getDecimal: function() {
return {
Expand Down
2 changes: 0 additions & 2 deletions src/values/GlobeCoordinateValue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ var SELF
longitude: globeCoordinate.getLongitude(),
globe: globeCoordinate.getGlobe(),
precision: globeCoordinate.getPrecision()
// altitude: ...
};
}
} );
Expand All @@ -91,7 +90,6 @@ SELF.newFromJSON = function( json ) {
longitude: json.longitude,
globe: json.globe,
precision: json.precision
// altitude: json.altitude, // TODO: make globeCoordinate.js support altitude
} );

return new SELF( gc );
Expand Down