Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make stuff private and clean up docs #21

Merged
merged 1 commit into from
Dec 19, 2014
Merged

Make stuff private and clean up docs #21

merged 1 commit into from
Dec 19, 2014

Conversation

thiemowmde
Copy link
Contributor

  • Make stuff private if possible.
  • Remove @see from private stuff.
  • Remove non-informational docs.
  • Rewrite a test to use expectedException.
  • Optimize use clauses.

JeroenDeDauw
JeroenDeDauw reviewed Dec 19, 2014
View reviewed changes
src/Patcher/ThrowingPatcher.php
* @var boolean
*/
protected $throwErrors;
private $throwErrors;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking change. Don't forget to put it into the release notes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already done in 6013934.

JeroenDeDauw added a commit that referenced this pull request Dec 19, 2014
@JeroenDeDauw
Merge pull request #21 from wmde/cleanup
b826b74 
Make stuff private and clean up docs
@JeroenDeDauw JeroenDeDauw merged commit b826b74 into master Dec 19, 2014
@JeroenDeDauw JeroenDeDauw deleted the cleanup branch December 19, 2014 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiemowmde @JeroenDeDauw